-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop time when used as a tag or field key #7132
Conversation
@jsternberg, thanks for your PR! By analyzing the annotation information on this pull request, we identified @e-dard to be a potential reviewer |
Is this a breaking change? Even though a |
That's a good point. I think this would classify as a breaking change. Comments @pauldix is dropping it ok or should we find a way to make this queryable? |
@@ -447,6 +447,17 @@ func (s *Shard) validateSeriesAndFields(points []models.Point) ([]*FieldCreate, | |||
|
|||
// get the shard mutex for locally defined fields | |||
for _, p := range points { | |||
// verify the tags and fields | |||
tags := p.Tags() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the right place to reject this as it will fail the whole batch instead of the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would also have that issue with the max series error. We may want to look into that again if we have the time.
Dropping and adding in the log seems like an ok approach to keep anyone from breaking now. But longer term I think that makes it less usable for new users. If you fail the write then any new user coming in would get immediate feedback that what they're doing isn't supported. Users frequently don't have access to the logs. I'm ok with the breaking change if we get it before 1.0. Otherwise, drop and warn would have to be it. |
35fd188
to
ff0bc30
Compare
The "time" field and tags are unqueryable so we prevent those from being written so we don't have unreadable data.
ff0bc30
to
9621bee
Compare
I dropped it and I added a |
👍 the 2.0 TODO will be useful. Although it feels like it should be a GH issue of wiki page so updating it doesn't require a PR. |
@gunnaraasen my idea was that people would update it whenever we made a change like this where we worked around something. I'll merge this and we can always remove it later if we decide that a wiki would be better. |
The "time" field and tags are unqueryable so we prevent those from being
written so we don't have unreadable data.
Fixes #1834.